Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch alternate names editor delimiter to newline instead of semicolon #8366

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Switch alternate names editor delimiter to newline instead of semicolon #8366

merged 2 commits into from
Oct 5, 2023

Conversation

sbwhitt
Copy link
Collaborator

@sbwhitt sbwhitt commented Oct 4, 2023

Closes #8183

Alternate names are separated by newlines instead of semicolons for easier editing.

Technical

Testing

Go to the author edit page, add and remove values separated by newlines and save to verify results.

Screenshot

image

Stakeholders

@cdrini

@davidscotson davidscotson mentioned this pull request Oct 4, 2023
Merged
cdrini
cdrini approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice this is so much easier to work with! Thank you @sbwhitt ! Tested on testing, editing/saving works like a charm!

@cdrini cdrini merged commit 35d6b72 into internetarchive:master Oct 5, 2023
3 checks passed
@RayBB
Copy link
Collaborator

RayBB commented Oct 5, 2023

I love this good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini approved these changes

Assignees

@cdrini cdrini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better Editor for "Alternative Names"
3 participants
@sbwhitt @RayBB @cdrini