Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed old i18n code #8373

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

piyush-poddar
Copy link
Contributor

@piyush-poddar piyush-poddar commented Oct 5, 2023

Closes #8336

Refactor: Removed the old i18n code

Technical

Testing

Screenshot

Stakeholders

@RayBB
Copy link
Collaborator

RayBB commented Oct 5, 2023

One thing we could potentially do is also remove references to this type from the db dump. However, I'm not sure if the dump should be edited manually.

Git diff of what we could remove.

diff --git a/scripts/dev-instance/dev_db.pg_dump b/scripts/dev-instance/dev_db.pg_dump
index adc3f4204..1f968295a 100644
--- a/scripts/dev-instance/dev_db.pg_dump
+++ b/scripts/dev-instance/dev_db.pg_dump
@@ -1747,7 +1747,6 @@ COPY public.data (thing_id, revision, data) FROM stdin;
 36	1	{"kind": "regular", "name": "Library", "created": {"type": "/type/datetime", "value": "2013-03-20T10:27:03.232297"}, "last_modified": {"type": "/type/datetime", "value": "2013-03-20T10:27:03.232297"}, "latest_revision": 1, "key": "/type/library", "type": {"key": "/type/type"}, "properties": [{"expected_type": {"key": "/type/text"}, "unique": true, "type": {"key": "/type/property"}, "name": "ip_ranges"}, {"expected_type": {"key": "/type/string"}, "unique": true, "type": {"key": "/type/property"}, "name": "website"}], "revision": 1}
 37	1	{"kind": "regular", "created": {"type": "/type/datetime", "value": "2013-03-20T10:27:03.232297"}, "properties": [{"expected_type": {"key": "/type/string"}, "unique": true, "type": {"key": "/type/property"}, "name": "name"}], "last_modified": {"type": "/type/datetime", "value": "2013-03-20T10:27:03.232297"}, "latest_revision": 1, "key": "/type/subject", "type": {"key": "/type/type"}, "backreferences": [{"expected_type": {"key": "/type/work"}, "type": {"key": "/type/backreference"}, "name": "works", "property_name": "subjects"}], "revision": 1}
 9	2	{"kind": "embeddable", "name": "Property", "created": {"type": "/type/datetime", "value": "2013-03-20T10:27:01.322813"}, "last_modified": {"type": "/type/datetime", "value": "2013-03-20T10:27:03.232297"}, "latest_revision": 2, "key": "/type/property", "type": {"key": "/type/type"}, "properties": [{"expected_type": {"key": "/type/string"}, "unique": true, "type": {"key": "/type/property"}, "name": "name"}, {"expected_type": {"key": "/type/type"}, "unique": true, "type": {"key": "/type/property"}, "name": "expected_type"}, {"expected_type": {"key": "/type/boolean"}, "unique": true, "type": {"key": "/type/property"}, "name": "unique"}], "revision": 2}
-38	1	{"kind": "regular", "name": "i18n strings", "created": {"type": "/type/datetime", "value": "2013-03-20T10:27:03.232297"}, "last_modified": {"type": "/type/datetime", "value": "2013-03-20T10:27:03.232297"}, "latest_revision": 1, "key": "/type/i18n", "revision": 1, "type": {"key": "/type/type"}, "description": {"type": "/type/text", "value": "Type for storing internationalization strings"}}
 13	2	{"kind": "regular", "created": {"type": "/type/datetime", "value": "2013-03-20T10:27:01.322813"}, "last_modified": {"type": "/type/datetime", "value": "2013-03-20T10:27:03.232297"}, "latest_revision": 2, "key": "/type/permission", "type": {"key": "/type/type"}, "properties": [{"expected_type": {"key": "/type/text"}, "unique": true, "type": {"key": "/type/property"}, "name": "description"}, {"expected_type": {"key": "/type/text"}, "unique": true, "type": {"key": "/type/property"}, "name": "description"}, {"expected_type": {"key": "/type/usergroup"}, "unique": false, "type": {"key": "/type/property"}, "name": "readers"}, {"expected_type": {"key": "/type/usergroup"}, "unique": false, "type": {"key": "/type/property"}, "name": "readers"}, {"expected_type": {"key": "/type/usergroup"}, "unique": false, "type": {"key": "/type/property"}, "name": "writers"}, {"expected_type": {"key": "/type/usergroup"}, "unique": false, "type": {"key": "/type/property"}, "name": "writers"}, {"expected_type": {"key": "/type/usergroup"}, "unique": false, "type": {"key": "/type/property"}, "name": "admins"}, {"expected_type": {"key": "/type/usergroup"}, "unique": false, "type": {"key": "/type/property"}, "name": "admins"}], "revision": 2}
 39	1	{"kind": "embeddable", "name": "Contribution", "created": {"type": "/type/datetime", "value": "2013-03-20T10:27:03.232297"}, "last_modified": {"type": "/type/datetime", "value": "2013-03-20T10:27:03.232297"}, "latest_revision": 1, "key": "/type/contribution", "type": {"key": "/type/type"}, "properties": [{"expected_type": {"key": "/type/string"}, "unique": true, "type": {"key": "/type/property"}, "name": "role"}, {"expected_type": {"key": "/type/string"}, "unique": true, "type": {"key": "/type/property"}, "name": "contributor"}], "revision": 1}
 40	1	{"kind": "regular", "name": "Macro", "created": {"type": "/type/datetime", "value": "2013-03-20T10:27:03.232297"}, "last_modified": {"type": "/type/datetime", "value": "2013-03-20T10:27:03.232297"}, "latest_revision": 1, "key": "/type/macro", "type": {"key": "/type/type"}, "properties": [{"expected_type": {"key": "/type/text"}, "unique": true, "type": {"key": "/type/property"}, "name": "macro"}, {"expected_type": {"key": "/type/string"}, "unique": true, "type": {"key": "/type/property"}, "name": "description"}], "revision": 1}
@@ -5627,7 +5626,6 @@ COPY public.thing (id, key, type, latest_revision, created, last_modified) FROM
 35	/type/list	1	1	2013-03-20 10:27:03.232297	2013-03-20 10:27:03.232297
 36	/type/library	1	1	2013-03-20 10:27:03.232297	2013-03-20 10:27:03.232297
 37	/type/subject	1	1	2013-03-20 10:27:03.232297	2013-03-20 10:27:03.232297
-38	/type/i18n	1	1	2013-03-20 10:27:03.232297	2013-03-20 10:27:03.232297
 39	/type/contribution	1	1	2013-03-20 10:27:03.232297	2013-03-20 10:27:03.232297
 40	/type/macro	1	1	2013-03-20 10:27:03.232297	2013-03-20 10:27:03.232297
 41	/type/home	1	1	2013-03-20 10:27:03.232297	2013-03-20 10:27:03.232297
@@ -6290,7 +6288,7 @@ COPY public.transaction (id, action, author_id, ip, comment, bot, created, chang
 2	new-account	24	127.0.0.1	Created new account.	f	2013-03-20 10:27:02.430771	[{"key": "/people/admin", "revision": 1}, {"key": "/people/admin/usergroup", "revision": 1}, {"key": "/people/admin/permission", "revision": 1}]	{}
 3	new-account	27	127.0.0.1	Created new account.	f	2013-03-20 10:27:02.591679	[{"key": "/people/AccountBot", "revision": 1}, {"key": "/people/AccountBot/usergroup", "revision": 1}, {"key": "/people/AccountBot/permission", "revision": 1}]	{}
 4	bulk_update	\N	127.0.0.1	\N	f	2013-03-20 10:27:02.727859	[{"key": "/usergroup/admin", "revision": 2}]	{}
-5	bulk_update	24	127.0.0.1	install	f	2013-03-20 10:27:03.232297	[{"key": "/type/rawtext", "revision": 1}, {"key": "/type/edition", "revision": 1}, {"key": "/type/i18n_page", "revision": 1}, {"key": "/type/link", "revision": 1}, {"key": "/type/scan_record", "revision": 1}, {"key": "/type/list", "revision": 1}, {"key": "/type/library", "revision": 1}, {"key": "/type/subject", "revision": 1}, {"key": "/type/property", "revision": 2}, {"key": "/type/i18n", "revision": 1}, {"key": "/type/permission", "revision": 2}, {"key": "/type/contribution", "revision": 1}, {"key": "/type/macro", "revision": 1}, {"key": "/type/home", "revision": 1}, {"key": "/type/publisher", "revision": 1}, {"key": "/type/author_role", "revision": 1}, {"key": "/type/uri", "revision": 1}, {"key": "/type/scan_location", "revision": 1}, {"key": "/type/type", "revision": 3}, {"key": "/type/work", "revision": 1}, {"key": "/type/template", "revision": 1}, {"key": "/type/collection", "revision": 1}, {"key": "/type/backreference", "revision": 2}, {"key": "/type/usergroup", "revision": 2}, {"key": "/type/content", "revision": 1}, {"key": "/type/page", "revision": 1}, {"key": "/type/place", "revision": 1}, {"key": "/type/user", "revision": 2}, {"key": "/type/object", "revision": 2}, {"key": "/type/toc_item", "revision": 1}, {"key": "/type/redirect", "revision": 2}, {"key": "/type/doc", "revision": 1}, {"key": "/type/translated_string", "revision": 1}, {"key": "/type/series", "revision": 1}, {"key": "/type/language", "revision": 1}, {"key": "/type/author", "revision": 1}, {"key": "/type/volume", "revision": 1}, {"key": "/type/delete", "revision": 2}]	{}
+5	bulk_update	24	127.0.0.1	install	f	2013-03-20 10:27:03.232297	[{"key": "/type/rawtext", "revision": 1}, {"key": "/type/edition", "revision": 1}, {"key": "/type/i18n_page", "revision": 1}, {"key": "/type/link", "revision": 1}, {"key": "/type/scan_record", "revision": 1}, {"key": "/type/list", "revision": 1}, {"key": "/type/library", "revision": 1}, {"key": "/type/subject", "revision": 1}, {"key": "/type/property", "revision": 2}, {"key": "/type/permission", "revision": 2}, {"key": "/type/contribution", "revision": 1}, {"key": "/type/macro", "revision": 1}, {"key": "/type/home", "revision": 1}, {"key": "/type/publisher", "revision": 1}, {"key": "/type/author_role", "revision": 1}, {"key": "/type/uri", "revision": 1}, {"key": "/type/scan_location", "revision": 1}, {"key": "/type/type", "revision": 3}, {"key": "/type/work", "revision": 1}, {"key": "/type/template", "revision": 1}, {"key": "/type/collection", "revision": 1}, {"key": "/type/backreference", "revision": 2}, {"key": "/type/usergroup", "revision": 2}, {"key": "/type/content", "revision": 1}, {"key": "/type/page", "revision": 1}, {"key": "/type/place", "revision": 1}, {"key": "/type/user", "revision": 2}, {"key": "/type/object", "revision": 2}, {"key": "/type/toc_item", "revision": 1}, {"key": "/type/redirect", "revision": 2}, {"key": "/type/doc", "revision": 1}, {"key": "/type/translated_string", "revision": 1}, {"key": "/type/series", "revision": 1}, {"key": "/type/language", "revision": 1}, {"key": "/type/author", "revision": 1}, {"key": "/type/volume", "revision": 1}, {"key": "/type/delete", "revision": 2}]	{}
 6	bulk_update	24	127.0.0.1	install	f	2013-03-20 10:27:04.6408	[{"key": "/pagelist", "revision": 1}, {"key": "/type", "revision": 1}, {"key": "/config/edition", "revision": 1}, {"key": "/languages/aar", "revision": 1}, {"key": "/languages/abk", "revision": 1}, {"key": "/languages/ace", "revision": 1}, {"key": "/languages/ach", "revision": 1}, {"key": "/languages/ada", "revision": 1}, {"key": "/languages/ady", "revision": 1}, {"key": "/languages/afa", "revision": 1}, {"key": "/languages/afr", "revision": 1}, {"key": "/languages/aka", "revision": 1}, {"key": "/languages/akk", "revision": 1}, {"key": "/languages/alb", "revision": 1}, {"key": "/languages/ale", "revision": 1}, {"key": "/languages/alg", "revision": 1}, {"key": "/languages/alt", "revision": 1}, {"key": "/languages/amh", "revision": 1}, {"key": "/languages/ang", "revision": 1}, {"key": "/languages/apa", "revision": 1}, {"key": "/languages/ara", "revision": 1}, {"key": "/languages/arc", "revision": 1}, {"key": "/languages/arg", "revision": 1}, {"key": "/languages/arm", "revision": 1}, {"key": "/languages/arn", "revision": 1}, {"key": "/languages/arp", "revision": 1}, {"key": "/languages/art", "revision": 1}, {"key": "/languages/arw", "revision": 1}, {"key": "/languages/ase", "revision": 1}, {"key": "/languages/asm", "revision": 1}, {"key": "/languages/ast", "revision": 1}, {"key": "/languages/ath", "revision": 1}, {"key": "/languages/aus", "revision": 1}, {"key": "/languages/ava", "revision": 1}, {"key": "/languages/ave", "revision": 1}, {"key": "/languages/awa", "revision": 1}, {"key": "/languages/aym", "revision": 1}, {"key": "/languages/aze", "revision": 1}, {"key": "/languages/bai", "revision": 1}, {"key": "/languages/bak", "revision": 1}, {"key": "/languages/bal", "revision": 1}, {"key": "/languages/bam", "revision": 1}, {"key": "/languages/ban", "revision": 1}, {"key": "/languages/baq", "revision": 1}, {"key": "/languages/bas", "revision": 1}, {"key": "/languages/bat", "revision": 1}, {"key": "/languages/bel", "revision": 1}, {"key": "/languages/bem", "revision": 1}, {"key": "/languages/ben", "revision": 1}, {"key": "/languages/ber", "revision": 1}, {"key": "/languages/bho", "revision": 1}, {"key": "/languages/bik", "revision": 1}, {"key": "/languages/bin", "revision": 1}, {"key": "/languages/bis", "revision": 1}, {"key": "/languages/bla", "revision": 1}, {"key": "/languages/bnt", "revision": 1}, {"key": "/languages/bos", "revision": 1}, {"key": "/languages/bra", "revision": 1}, {"key": "/languages/bre", "revision": 1}, {"key": "/languages/btk", "revision": 1}, {"key": "/languages/bua", "revision": 1}, {"key": "/languages/bug", "revision": 1}, {"key": "/languages/bul", "revision": 1}, {"key": "/languages/bur", "revision": 1}, {"key": "/languages/cai", "revision": 1}, {"key": "/languages/cam", "revision": 1}, {"key": "/languages/car", "revision": 1}, {"key": "/languages/cat", "revision": 1}, {"key": "/languages/cau", "revision": 1}, {"key": "/languages/ceb", "revision": 1}, {"key": "/languages/cel", "revision": 1}, {"key": "/languages/che", "revision": 1}, {"key": "/languages/chg", "revision": 1}, {"key": "/languages/chi", "revision": 1}, {"key": "/languages/chk", "revision": 1}, {"key": "/languages/chm", "revision": 1}, {"key": "/languages/chn", "revision": 1}, {"key": "/languages/cho", "revision": 1}, {"key": "/languages/chr", "revision": 1}, {"key": "/languages/chu", "revision": 1}, {"key": "/languages/chv", "revision": 1}, {"key": "/languages/chy", "revision": 1}, {"key": "/languages/cmc", "revision": 1}, {"key": "/languages/cmn", "revision": 1}, {"key": "/languages/cop", "revision": 1}, {"key": "/languages/cor", "revision": 1}, {"key": "/languages/cos", "revision": 1}, {"key": "/languages/cpe", "revision": 1}, {"key": "/languages/cpf", "revision": 1}, {"key": "/languages/cpp", "revision": 1}, {"key": "/languages/cre", "revision": 1}, {"key": "/languages/crh", "revision": 1}, {"key": "/languages/crp", "revision": 1}, {"key": "/languages/cus", "revision": 1}, {"key": "/languages/cze", "revision": 1}, {"key": "/languages/dak", "revision": 1}, {"key": "/languages/dan", "revision": 1}, {"key": "/languages/dar", "revision": 1}, {"key": "/languages/day", "revision": 1}, {"key": "/languages/del", "revision": 1}, {"key": "/languages/din", "revision": 1}, {"key": "/languages/div", "revision": 1}, {"key": "/languages/doi", "revision": 1}, {"key": "/languages/dra", "revision": 1}, {"key": "/languages/dua", "revision": 1}, {"key": "/languages/dum", "revision": 1}, {"key": "/languages/dut", "revision": 1}, {"key": "/languages/dyu", "revision": 1}, {"key": "/languages/dzo", "revision": 1}, {"key": "/languages/efi", "revision": 1}, {"key": "/languages/egy", "revision": 1}, {"key": "/languages/eka", "revision": 1}, {"key": "/languages/elx", "revision": 1}, {"key": "/languages/eng", "revision": 1}, {"key": "/languages/enm", "revision": 1}, {"key": "/languages/epo", "revision": 1}, {"key": "/languages/esk", "revision": 1}, {"key": "/languages/esp", "revision": 1}, {"key": "/languages/est", "revision": 1}, {"key": "/languages/eth", "revision": 1}, {"key": "/languages/ewe", "revision": 1}, {"key": "/languages/ewo", "revision": 1}, {"key": "/languages/fan", "revision": 1}, {"key": "/languages/fao", "revision": 1}, {"key": "/languages/far", "revision": 1}, {"key": "/languages/fat", "revision": 1}, {"key": "/languages/fij", "revision": 1}, {"key": "/languages/fil", "revision": 1}, {"key": "/languages/fin", "revision": 1}, {"key": "/languages/fiu", "revision": 1}, {"key": "/languages/fon", "revision": 1}, {"key": "/languages/fre", "revision": 1}, {"key": "/languages/fri", "revision": 1}, {"key": "/languages/frm", "revision": 1}, {"key": "/languages/fro", "revision": 1}, {"key": "/languages/frs", "revision": 1}, {"key": "/languages/fry", "revision": 1}, {"key": "/languages/ful", "revision": 1}, {"key": "/languages/fur", "revision": 1}, {"key": "/languages/gaa", "revision": 1}, {"key": "/languages/gae", "revision": 1}, {"key": "/languages/gag", "revision": 1}, {"key": "/languages/gal", "revision": 1}, {"key": "/languages/gay", "revision": 1}, {"key": "/languages/gba", "revision": 1}, {"key": "/languages/gem", "revision": 1}, {"key": "/languages/geo", "revision": 1}, {"key": "/languages/ger", "revision": 1}, {"key": "/languages/gez", "revision": 1}, {"key": "/languages/gil", "revision": 1}, {"key": "/languages/gla", "revision": 1}, {"key": "/languages/gle", "revision": 1}, {"key": "/languages/glg", "revision": 1}, {"key": "/languages/glv", "revision": 1}, {"key": "/languages/gmh", "revision": 1}, {"key": "/languages/goh", "revision": 1}, {"key": "/languages/gon", "revision": 1}, {"key": "/languages/gor", "revision": 1}, {"key": "/languages/got", "revision": 1}, {"key": "/languages/grb", "revision": 1}, {"key": "/languages/grc", "revision": 1}, {"key": "/languages/gre", "revision": 1}, {"key": "/languages/grn", "revision": 1}, {"key": "/languages/gsw", "revision": 1}, {"key": "/languages/gua", "revision": 1}, {"key": "/languages/guj", "revision": 1}, {"key": "/languages/gul", "revision": 1}, {"key": "/languages/hat", "revision": 1}, {"key": "/languages/hau", "revision": 1}, {"key": "/languages/haw", "revision": 1}, {"key": "/languages/hbs", "revision": 1}, {"key": "/languages/heb", "revision": 1}, {"key": "/languages/her", "revision": 1}, {"key": "/languages/hil", "revision": 1}, {"key": "/languages/him", "revision": 1}, {"key": "/languages/hin", "revision": 1}, {"key": "/languages/hmn", "revision": 1}, {"key": "/languages/hmo", "revision": 1}, {"key": "/languages/hrv", "revision": 1}, {"key": "/languages/hun", "revision": 1}, {"key": "/languages/iba", "revision": 1}, {"key": "/languages/ibo", "revision": 1}, {"key": "/languages/ice", "revision": 1}, {"key": "/languages/ido", "revision": 1}, {"key": "/languages/ijo", "revision": 1}, {"key": "/languages/iku", "revision": 1}, {"key": "/languages/ilo", "revision": 1}, {"key": "/languages/ina", "revision": 1}, {"key": "/languages/inc", "revision": 1}, {"key": "/languages/ind", "revision": 1}, {"key": "/languages/ine", "revision": 1}, {"key": "/languages/inh", "revision": 1}, {"key": "/languages/int", "revision": 1}, {"key": "/languages/ipk", "revision": 1}, {"key": "/languages/ira", "revision": 1}, {"key": "/languages/iri", "revision": 1}, {"key": "/languages/iro", "revision": 1}, {"key": "/languages/ita", "revision": 1}, {"key": "/languages/jav", "revision": 1}, {"key": "/languages/jpn", "revision": 1}, {"key": "/languages/jpr", "revision": 1}, {"key": "/languages/jrb", "revision": 1}, {"key": "/languages/kaa", "revision": 1}, {"key": "/languages/kab", "revision": 1}, {"key": "/languages/kac", "revision": 1}, {"key": "/languages/kal", "revision": 1}, {"key": "/languages/kam", "revision": 1}, {"key": "/languages/kan", "revision": 1}, {"key": "/languages/kar", "revision": 1}, {"key": "/languages/kas", "revision": 1}, {"key": "/languages/kau", "revision": 1}, {"key": "/languages/kaw", "revision": 1}, {"key": "/languages/kaz", "revision": 1}, {"key": "/languages/kbd", "revision": 1}, {"key": "/languages/kha", "revision": 1}, {"key": "/languages/khi", "revision": 1}, {"key": "/languages/khm", "revision": 1}, {"key": "/languages/kho", "revision": 1}, {"key": "/languages/kik", "revision": 1}, {"key": "/languages/kin", "revision": 1}, {"key": "/languages/kir", "revision": 1}, {"key": "/languages/kmb", "revision": 1}, {"key": "/languages/kok", "revision": 1}, {"key": "/languages/kom", "revision": 1}, {"key": "/languages/kon", "revision": 1}, {"key": "/languages/kor", "revision": 1}, {"key": "/languages/kos", "revision": 1}, {"key": "/languages/kpe", "revision": 1}, {"key": "/languages/krc", "revision": 1}, {"key": "/languages/krl", "revision": 1}, {"key": "/languages/kro", "revision": 1}, {"key": "/languages/kru", "revision": 1}, {"key": "/languages/kua", "revision": 1}, {"key": "/languages/kum", "revision": 1}, {"key": "/languages/kur", "revision": 1}, {"key": "/languages/lad", "revision": 1}, {"key": "/languages/lah", "revision": 1}, {"key": "/languages/lam", "revision": 1}, {"key": "/languages/lan", "revision": 1}, {"key": "/languages/lao", "revision": 1}, {"key": "/languages/lap", "revision": 1}, {"key": "/languages/lat", "revision": 1}, {"key": "/languages/lav", "revision": 1}, {"key": "/languages/lez", "revision": 1}, {"key": "/languages/lin", "revision": 1}, {"key": "/languages/lit", "revision": 1}, {"key": "/languages/lol", "revision": 1}, {"key": "/languages/loz", "revision": 1}, {"key": "/languages/ltz", "revision": 1}, {"key": "/languages/lua", "revision": 1}, {"key": "/languages/lub", "revision": 1}, {"key": "/languages/lug", "revision": 1}, {"key": "/languages/lun", "revision": 1}, {"key": "/languages/luo", "revision": 1}, {"key": "/languages/lus", "revision": 1}, {"key": "/languages/mac", "revision": 1}, {"key": "/languages/mad", "revision": 1}, {"key": "/languages/mag", "revision": 1}, {"key": "/languages/mah", "revision": 1}, {"key": "/languages/mai", "revision": 1}, {"key": "/languages/mak", "revision": 1}, {"key": "/languages/mal", "revision": 1}, {"key": "/languages/man", "revision": 1}, {"key": "/languages/mao", "revision": 1}, {"key": "/languages/map", "revision": 1}, {"key": "/languages/mar", "revision": 1}, {"key": "/languages/mas", "revision": 1}, {"key": "/languages/may", "revision": 1}, {"key": "/languages/mdf", "revision": 1}, {"key": "/languages/men", "revision": 1}, {"key": "/languages/mic", "revision": 1}, {"key": "/languages/min", "revision": 1}, {"key": "/languages/mis", "revision": 1}, {"key": "/languages/mkh", "revision": 1}, {"key": "/languages/mla", "revision": 1}, {"key": "/languages/mlg", "revision": 1}, {"key": "/languages/mlt", "revision": 1}, {"key": "/languages/mnc", "revision": 1}, {"key": "/languages/mni", "revision": 1}, {"key": "/languages/mno", "revision": 1}, {"key": "/languages/moh", "revision": 1}, {"key": "/languages/mol", "revision": 1}, {"key": "/languages/mon", "revision": 1}, {"key": "/languages/mos", "revision": 1}, {"key": "/languages/mul", "revision": 1}, {"key": "/languages/mun", "revision": 1}, {"key": "/languages/mus", "revision": 1}, {"key": "/languages/mwr", "revision": 1}, {"key": "/languages/myn", "revision": 1}, {"key": "/languages/myv", "revision": 1}, {"key": "/languages/nah", "revision": 1}, {"key": "/languages/nai", "revision": 1}, {"key": "/languages/nau", "revision": 1}, {"key": "/languages/nav", "revision": 1}, {"key": "/languages/nbl", "revision": 1}, {"key": "/languages/nde", "revision": 1}, {"key": "/languages/ndo", "revision": 1}, {"key": "/languages/nds", "revision": 1}, {"key": "/languages/nep", "revision": 1}, {"key": "/languages/new", "revision": 1}, {"key": "/languages/nic", "revision": 1}, {"key": "/languages/niu", "revision": 1}, {"key": "/languages/nno", "revision": 1}, {"key": "/languages/nob", "revision": 1}, {"key": "/languages/nog", "revision": 1}, {"key": "/languages/non", "revision": 1}, {"key": "/languages/nor", "revision": 1}, {"key": "/languages/nso", "revision": 1}, {"key": "/languages/nub", "revision": 1}, {"key": "/languages/nya", "revision": 1}, {"key": "/languages/nyn", "revision": 1}, {"key": "/languages/nyo", "revision": 1}, {"key": "/languages/nzi", "revision": 1}, {"key": "/languages/oci", "revision": 1}, {"key": "/languages/oji", "revision": 1}, {"key": "/languages/ori", "revision": 1}, {"key": "/languages/orm", "revision": 1}, {"key": "/languages/osa", "revision": 1}, {"key": "/languages/oss", "revision": 1}, {"key": "/languages/ota", "revision": 1}, {"key": "/languages/oto", "revision": 1}, {"key": "/languages/paa", "revision": 1}, {"key": "/languages/pag", "revision": 1}, {"key": "/languages/pal", "revision": 1}, {"key": "/languages/pam", "revision": 1}, {"key": "/languages/pan", "revision": 1}, {"key": "/languages/pap", "revision": 1}, {"key": "/languages/pau", "revision": 1}, {"key": "/languages/peo", "revision": 1}, {"key": "/languages/per", "revision": 1}, {"key": "/languages/phi", "revision": 1}, {"key": "/languages/pli", "revision": 1}, {"key": "/languages/pol", "revision": 1}, {"key": "/languages/pon", "revision": 1}, {"key": "/languages/por", "revision": 1}, {"key": "/languages/pra", "revision": 1}, {"key": "/languages/pro", "revision": 1}, {"key": "/languages/pus", "revision": 1}, {"key": "/languages/que", "revision": 1}, {"key": "/languages/raj", "revision": 1}, {"key": "/languages/rar", "revision": 1}, {"key": "/languages/roa", "revision": 1}, {"key": "/languages/roh", "revision": 1}, {"key": "/languages/rom", "revision": 1}, {"key": "/languages/rum", "revision": 1}, {"key": "/languages/run", "revision": 1}, {"key": "/languages/rus", "revision": 1}, {"key": "/languages/sag", "revision": 1}, {"key": "/languages/sah", "revision": 1}, {"key": "/languages/sai", "revision": 1}, {"key": "/languages/sal", "revision": 1}, {"key": "/languages/sam", "revision": 1}, {"key": "/languages/san", "revision": 1}, {"key": "/languages/sao", "revision": 1}, {"key": "/languages/sas", "revision": 1}, {"key": "/languages/sat", "revision": 1}, {"key": "/languages/scc", "revision": 1}, {"key": "/languages/sco", "revision": 1}, {"key": "/languages/scr", "revision": 1}, {"key": "/languages/sel", "revision": 1}, {"key": "/languages/sem", "revision": 1}, {"key": "/languages/shn", "revision": 1}, {"key": "/languages/sho", "revision": 1}, {"key": "/languages/sid", "revision": 1}, {"key": "/languages/sin", "revision": 1}, {"key": "/languages/sio", "revision": 1}, {"key": "/languages/sit", "revision": 1}, {"key": "/languages/sla", "revision": 1}, {"key": "/languages/slo", "revision": 1}, {"key": "/languages/slv", "revision": 1}, {"key": "/languages/sme", "revision": 1}, {"key": "/languages/smi", "revision": 1}, {"key": "/languages/smo", "revision": 1}, {"key": "/languages/sna", "revision": 1}, {"key": "/languages/snd", "revision": 1}, {"key": "/languages/snh", "revision": 1}, {"key": "/languages/snk", "revision": 1}, {"key": "/languages/sog", "revision": 1}, {"key": "/languages/som", "revision": 1}, {"key": "/languages/son", "revision": 1}, {"key": "/languages/sot", "revision": 1}, {"key": "/languages/spa", "revision": 1}, {"key": "/languages/srd", "revision": 1}, {"key": "/languages/srn", "revision": 1}, {"key": "/languages/srp", "revision": 1}, {"key": "/languages/srr", "revision": 1}, {"key": "/languages/ssa", "revision": 1}, {"key": "/languages/sso", "revision": 1}, {"key": "/languages/ssw", "revision": 1}, {"key": "/languages/suk", "revision": 1}, {"key": "/languages/sun", "revision": 1}, {"key": "/languages/sus", "revision": 1}, {"key": "/languages/sux", "revision": 1}, {"key": "/languages/swa", "revision": 1}, {"key": "/languages/swe", "revision": 1}, {"key": "/languages/swz", "revision": 1}, {"key": "/languages/syc", "revision": 1}, {"key": "/languages/syr", "revision": 1}, {"key": "/languages/tag", "revision": 1}, {"key": "/languages/tah", "revision": 1}, {"key": "/languages/tai", "revision": 1}, {"key": "/languages/taj", "revision": 1}, {"key": "/languages/tam", "revision": 1}, {"key": "/languages/tar", "revision": 1}, {"key": "/languages/tat", "revision": 1}, {"key": "/languages/tel", "revision": 1}, {"key": "/languages/tem", "revision": 1}, {"key": "/languages/ter", "revision": 1}, {"key": "/languages/tet", "revision": 1}, {"key": "/languages/tgk", "revision": 1}, {"key": "/languages/tgl", "revision": 1}, {"key": "/languages/tha", "revision": 1}, {"key": "/languages/tib", "revision": 1}, {"key": "/languages/tig", "revision": 1}, {"key": "/languages/tir", "revision": 1}, {"key": "/languages/tiv", "revision": 1}, {"key": "/languages/tkl", "revision": 1}, {"key": "/languages/tli", "revision": 1}, {"key": "/languages/tmh", "revision": 1}, {"key": "/languages/tog", "revision": 1}, {"key": "/languages/ton", "revision": 1}, {"key": "/languages/tpi", "revision": 1}, {"key": "/languages/tsi", "revision": 1}, {"key": "/languages/tsn", "revision": 1}, {"key": "/languages/tso", "revision": 1}, {"key": "/languages/tsw", "revision": 1}, {"key": "/languages/tuk", "revision": 1}, {"key": "/languages/tum", "revision": 1}, {"key": "/languages/tur", "revision": 1}, {"key": "/languages/tut", "revision": 1}, {"key": "/languages/tvl", "revision": 1}, {"key": "/languages/twi", "revision": 1}, {"key": "/languages/tyv", "revision": 1}, {"key": "/languages/udm", "revision": 1}, {"key": "/languages/uga", "revision": 1}, {"key": "/languages/uig", "revision": 1}, {"key": "/languages/ukr", "revision": 1}, {"key": "/languages/umb", "revision": 1}, {"key": "/languages/und", "revision": 1}, {"key": "/languages/urd", "revision": 1}, {"key": "/languages/uzb", "revision": 1}, {"key": "/languages/vai", "revision": 1}, {"key": "/languages/ven", "revision": 1}, {"key": "/languages/vie", "revision": 1}, {"key": "/languages/vls", "revision": 1}, {"key": "/languages/wak", "revision": 1}, {"key": "/languages/wal", "revision": 1}, {"key": "/languages/war", "revision": 1}, {"key": "/languages/wel", "revision": 1}, {"key": "/languages/wen", "revision": 1}, {"key": "/languages/wol", "revision": 1}, {"key": "/languages/xal", "revision": 1}, {"key": "/languages/xho", "revision": 1}, {"key": "/languages/yao", "revision": 1}, {"key": "/languages/yap", "revision": 1}, {"key": "/languages/yid", "revision": 1}, {"key": "/languages/yor", "revision": 1}, {"key": "/languages/ypk", "revision": 1}, {"key": "/languages/yue", "revision": 1}, {"key": "/languages/zap", "revision": 1}, {"key": "/languages/znd", "revision": 1}, {"key": "/languages/zul", "revision": 1}, {"key": "/languages/zun", "revision": 1}, {"key": "/languages/zza", "revision": 1}, {"key": "/", "revision": 1}]	{}
 7	new-account	524	127.0.0.1	Created new account.	f	2013-03-20 10:27:09.71738	[{"key": "/people/openlibrary", "revision": 1}, {"key": "/people/openlibrary/usergroup", "revision": 1}, {"key": "/people/openlibrary/permission", "revision": 1}]	{}
 8	update	24	127.0.0.1	Added openlibrary user to API usergroup.	f	2013-03-20 10:27:09.890834	[{"key": "/usergroup/api", "revision": 1}]	{}
@@ -6697,7 +6695,6 @@ COPY public.type_str (thing_id, key_id, value, ordering) FROM stdin;
 47	5	title	\N
 35	3	List	\N
 39	3	Contribution	\N
-38	3	i18n strings	\N
 1	19	1	\N
 1	19	2	\N
 1	19	0	\N

@jimchamp do you think it's okay to manually modify the dump? Or worth the effort?

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the dump question, the changes look as expected.
I double checked the codebase and don't see any references to i18n that could be referring to this.

Unfortunately, I'm not sure how to test that i18n still works.
@cdrini do you have suggestions for how to check this?

@RayBB RayBB added this to Waiting Review/Merge from Staff in Ray's Project Oct 6, 2023
@RayBB RayBB added the Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] label Oct 9, 2023
@RayBB
Copy link
Collaborator

RayBB commented Oct 9, 2023

@piyush-poddar replying to your comment from here. I don't have the power to merge. We need @mekarpeles or @cdrini to check it out.

@piyush-poddar
Copy link
Contributor Author

No problem mate, was just curious about my PR.
Thanks for the reply!

@cdrini
Copy link
Collaborator

cdrini commented Oct 25, 2023

This does look unused! Thanks @piyush-poddar and @RayBB !

@cdrini cdrini merged commit f3f228a into internetarchive:master Oct 25, 2023
3 checks passed
Ray's Project automation moved this from Waiting Review/Merge from Staff to Done Oct 25, 2023
@piyush-poddar
Copy link
Contributor Author

@cdrini Happy to contribute :)

@RayBB
Copy link
Collaborator

RayBB commented Oct 26, 2023

@piyush-poddar if you'd like to contribute further you're welcome to fill out the Volunteer form (https://openlibrary.org/volunteer) and join our slack or community call! There's lot of things to do :)

@piyush-poddar
Copy link
Contributor Author

@RayBB Thanks a lot!! I would surely do that.
Also, how can I connect with you if I need any help?

@RayBB
Copy link
Collaborator

RayBB commented Oct 28, 2023

You can message me on our Slack (which you should get an invite to after filling out the form!)
If you don't get one tag @mekarpeles here

@piyush-poddar
Copy link
Contributor Author

@RayBB Okay thanks!!

@piyush-poddar
Copy link
Contributor Author

piyush-poddar commented Nov 4, 2023

You can message me on our Slack (which you should get an invite to after filling out the form!) If you don't get one tag @mekarpeles here

@RayBB @mekarpeles I filled the volunteer form yesterday, however I still haven't received the slack invite.
Please send the slack invite.

@RayBB
Copy link
Collaborator

RayBB commented Nov 4, 2023

@mekarpeles can you check the form when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed]
Projects
Development

Successfully merging this pull request may close these issues.

Remove old i18n code
3 participants