-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix TypeChanger bug #8374
fix TypeChanger bug #8374
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8374 +/- ##
==========================================
- Coverage 16.66% 16.62% -0.05%
==========================================
Files 83 84 +1
Lines 4422 4433 +11
Branches 757 758 +1
==========================================
Hits 737 737
- Misses 3202 3212 +10
- Partials 483 484 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RayBB! I think that we do still want this functionality.
Will happily merge this once the suggested changes have been made.
Co-authored-by: jimchamp <jameschamp@acm.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RayBB! This looks good to me.
Contributes to #4474
I was investigating moving the JS to be inline but couldn't figure out how the functionality works.
Turns out it didn't work at all. Perhaps because the code is 12 years old and not used too frequently.
This PR makes the code actually work and moves it away from being inline js.
Technical
thinginput comes from here. It doesn't seem to pass the "onclick" field currently, hence the code wasn't working.
Testing
See video
Screenshot
typechanger.1.mp4
Stakeholders
@jimchamp are you interested in reviewing? Since you've helped with this epic before