Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unclosed div in MergeUI #8385

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Oct 6, 2023

When trying to build vue in development mode it was failing with an error (see below).

Turns out we had an unclosed div that the IDE was complaining about too.
The production mode was swallowing the error and browsers were probably making a lucky guess of where to end the div.

Contributes to #7547

Technical

Error I was getting

npx vue-cli-service build --no-clean --watch --mode development --dest static/build/components/prod
uction --target wc --name ol-MergeUI openlibrary/components/MergeUI.vue

⠋  Building for development as web component...

 ERROR  Failed to compile with 1 error                                                                                          9:32:00 AM

 error  in ./openlibrary/components/MergeUI.vue?vue&type=template&id=468bf6df&shadow

Module Error (from ./node_modules/@vue/vue-loader-v15/lib/loaders/templateLoader.js):
(Emitted value instead of an instance of Error) 

  Errors compiling template:

  tag <div> has no matching end tag.

  1  |  
     |   
  2  |  <div id="app">
     |  ^^^^^^^^^^^^^^
  3  |    <MergeTable :olids="olids" :show_diffs="show_diffs" :primary="primary" ref="mergeTable"/>

Testing

Check that diffs option still works fine (it does)

Screenshot

screenshot image

Stakeholders

@jimchamp

@codecov-commenter
Copy link

Codecov Report

Merging #8385 (0f7f431) into master (35d6b72) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8385   +/-   ##
=======================================
  Coverage   16.66%   16.66%           
=======================================
  Files          83       83           
  Lines        4422     4422           
  Branches      757      757           
=======================================
  Hits          737      737           
  Misses       3202     3202           
  Partials      483      483           

@RayBB RayBB added this to Waiting Review/Merge from Staff in Ray's Project Oct 6, 2023
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threw on testing looks good!

@cdrini cdrini merged commit fd69891 into internetarchive:master Oct 17, 2023
3 checks passed
Ray's Project automation moved this from Waiting Review/Merge from Staff to Done Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants