Fix author not pre-filling on new work #8431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mekarpeles
reviewed
Oct 18, 2023
| authors = (work and work.authors) or [] | ||
| if work and authors: | ||
| authors = [a.author for a in authors] | ||
| # pre-filling existing author if adding new work from author page | ||
| if author and author not in authors: |
There was a problem hiding this comment.
We could potentially leverage some of the work from https://github.com/internetarchive/openlibrary/blob/master/openlibrary/catalog/add_book/__init__.py#L801-L802 where we normalize/dedupe authors on import... But I think this PR is good for now!
|
lgtm, ty @sbwhitt! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8422
Prefills author name on add book page when adding a new work from the author page.
Technical
Testing
Go to an author's page. Select 'Add another?'. Verify that the author's name is already included in the author field for the new work.
Screenshot
Stakeholders
@mheiman @lephemere