Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change white-space to normal and text align center #8446

Merged

Conversation

pratishta
Copy link
Contributor

Closes #8376

Technical

Changed white-space to normal, but we could omit the attribute all together. text-align centered was just because everything else in that container is centered but I'm not hip to the design principles.

Testing

I've been unable to replicate a waiting list in my local environment. I know borrowing is not possible in the local environment but not sure if I'm missing any contributor docs to mock the waiting list info or force it in the local db. It's a fairly small change so I checked against the prod site for now

Screenshot

This is on the live prod site, using Firefox developer tools to toggle / change waitinglist-message.

Before:
image

After:
image

Stakeholders

@jimchamp

@cdrini cdrini merged commit fbdb3a5 into internetarchive:master Oct 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Waitlist UI/CSS Bug - text overflows when waitlist number is long
3 participants