Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Storybook after upgrade #8456

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

jimchamp
Copy link
Collaborator

Recent Webpack upgrades broke Storybook. This PR updates our Storybook code such that stories can be served on developer's local machines. The GitHub action which automatically deploys our Storybook instance to GitHub pages was removed, as it is obsolete. A new deployment action will be added in another PR.

Technical

Testing

Screenshot

Stakeholders

- Add required packages for Storybook
- Remove unused add-ons
- Add required `framework` configuration
- Rename `*.stories.mdx` files to `*.mdx` (otherwise MDX files are not
indexed)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Planning on adding new sections to this over time.
Future sections:

  • Deployment
  • Creating new stories

@mekarpeles mekarpeles merged commit 723b6c4 into internetarchive:master Oct 27, 2023
4 checks passed
@jimchamp jimchamp deleted the bug/fix-storybook branch November 8, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants