Hide ILE on pop-ups #8478
Merged
Hide ILE on pop-ups #8478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
added
the
On testing.openlibrary.org
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could have sworn I saw an issue for this, but now I can't find it anywhere.
The ILE blue bar appears on popups like the cover manager, when it should only show up on full pages. This PR adds a check to make sure this happens correctly.
Testing
Add some items to the blue bar, then (in the same tab) open the Manage Covers popup. Blue bar should not appear.
Screenshot
Before:
After:
Stakeholders
@mheiman @cdrini @seabelis