Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Want to Read dropper to lists #8491

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

sbwhitt
Copy link
Collaborator

@sbwhitt sbwhitt commented Nov 3, 2023

Closes #8206

Adds the Want to Read dropper to book options within lists.

Technical

Testing

  1. Go to a list with books added.
  2. The Want to Read dropper should display underneath the existing Read/Listen button.
  3. Selecting the dropper when logged out should redirect the user to the login page.
  4. Selecting options from the dropper while logged in should update the user's reading log as expected.

Screenshot

While logged in:

image

While logged out:
image

Stakeholders

@jimchamp

Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. This looks good to me.
Noting that the list dropper doesn't appear for authors and subjects, but that's probably fine for now. Will open an issue about this if it becomes a problem.

@jimchamp jimchamp merged commit c32d626 into internetarchive:master Nov 28, 2023
3 checks passed
@sbwhitt
Copy link
Collaborator Author

sbwhitt commented Nov 28, 2023

Sorry for the delay. This looks good to me. Noting that the list dropper doesn't appear for authors and subjects, but that's probably fine for now. Will open an issue about this if it becomes a problem.

No worries, thanks for reviewing. For the author page I opened this issue: #8520

@jimchamp
Copy link
Collaborator

Thanks for opening that issue and adding an assignee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Want to Read" buttons to book lists
2 participants