Add want to read dropper on author's page #8527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
jimchamp
changed the title
jimchamp
requested changes
Nov 28, 2023
There was a problem hiding this comment.
Thanks @benbdeitch!
It looks like the button's text is very small on these pages:
Updating the font-size to 1rem should fix it. That can be changed here:
Changed the font-size on the button from 1em to 1rem.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8527 +/- ##
==========================================
+ Coverage 16.00% 16.51% +0.51%
==========================================
Files 86 85 -1
Lines 4692 4456 -236
Branches 822 782 -40
==========================================
- Hits 751 736 -15
+ Misses 3416 3227 -189
+ Partials 525 493 -32 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8520
This pull request seeks to add the 'Want to Read' dropper onto the various books listed on an Author page.
Technical
It's a two line alteration, that imports and adds the dropper component to the calling of the searchResultsWork macro.