Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/my book dropper btn overflow #8528

Merged

Conversation

Achorn
Copy link
Contributor

@Achorn Achorn commented Nov 14, 2023

Closes #

fixes book dropper button text overflow wrapping

Technical

  • .generic-dropper__primary class was updated to keep the nowrap text from shrinking the dropdown button.
  • .book-progress-btn class was utilized to add overflow ellipsis when button shrinks

Testing

go to /works page and adjust screen width to see fix

Screenshot

Before

Screenshot 2023-11-14 at 3 51 04 PM

After

Screenshot 2023-11-14 at 3 50 30 PM

Stakeholders

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c6b3544) 16.00% compared to head (fbdb607) 16.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8528   +/-   ##
=======================================
  Coverage   16.00%   16.00%           
=======================================
  Files          86       86           
  Lines        4692     4692           
  Branches      822      822           
=======================================
  Hits          751      751           
  Misses       3416     3416           
  Partials      525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mekarpeles mekarpeles merged commit 9adcb87 into internetarchive:master Nov 17, 2023
3 checks passed
@mekarpeles
Copy link
Member

lgtm, tested on testing. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants