Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain selections on bulk subject submission #8533

Conversation

jimchamp
Copy link
Collaborator

Modifies bulk tag submission handler to prevent clearing selected works on successful submission. @mheiman mentions that this is likely the preferred experience, here.

Technical

Testing

While logged in with an account that can bulk tag works:

  1. Go to a search page.
  2. Select two or more items.
  3. Using the bulk tagger, add at least one subject to the selected works.
  4. Ensure that the selected works are still selected on success response.

Screenshot

Stakeholders

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (07d2cfa) 16.00% compared to head (6b878a4) 16.00%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8533   +/-   ##
=======================================
  Coverage   16.00%   16.00%           
=======================================
  Files          86       86           
  Lines        4692     4691    -1     
  Branches      822      822           
=======================================
  Hits          751      751           
+ Misses       3416     3415    -1     
  Partials      525      525           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mekarpeles mekarpeles merged commit c984701 into internetarchive:master Nov 17, 2023
3 checks passed
@mekarpeles mekarpeles self-assigned this Nov 17, 2023
@jimchamp jimchamp deleted the retain-selections-on-subject-submission branch November 17, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants