Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates /status for dev to include staged PRs #8556

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Conversation

mekarpeles
Copy link
Member

@mekarpeles mekarpeles commented Nov 22, 2023

Closes #

Technical

Testing

  • ✅ Works with no/empty dev merged
  • ✅ Works with full dev merged

Screenshot

image
image

Stakeholders

@cdrini cdrini self-assigned this Nov 24, 2023
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm now! _dev-merged.txt contains all PRs which we want to be on testing.openlibrary.org ; but some might be kicked off due to conflicts. Updated jenkins to tee its output during making the integration branch into a file, and reading that instead. Also added some extra stuff to make it link/condensed.

We can now use this to detect if a PR was kicked off!

@cdrini cdrini merged commit 4eedc06 into master Nov 24, 2023
3 checks passed
@cdrini cdrini deleted the status-staged-prs branch November 24, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants