Add more types to subjects.py #8560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
force-pushed
the
refactor/subjects-py
branch
from
cba7e01
to
5307ab2
Compare
cdrini
force-pushed
the
refactor/subjects-py
branch
from
5307ab2
to
3b3b9c2
Compare
cdrini
added
the
On testing.openlibrary.org
mekarpeles
reviewed
Nov 30, 2023
| Engine: type['SubjectEngine'] = SubjectEngine | ||
|
|
||
|
|
||
| SUBJECTS = [ |
There was a problem hiding this comment.
SUBJECTS is kind of confusing as a var name, makes me think its a list of strings or something. This is not a blocker, though proposing a cleanup of e.g.
Suggested change
| SUBJECTS = [ | |
| SUBJECT_META_ENGINES = [ |
|
One comment about var naming |
jimchamp
removed
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor. Add a dataclass for SubjectMeta, and make it a little less opaque how the Engine is found. Also add some more types.
Technical
Testing
Screenshot
Stakeholders