Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sort_option anchors nofollow to prevent crawling #8592

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Dec 6, 2023

Closes #8579 . Fix crawlers sometimes hitting the sort options, which can cause them to endlessly spiral.

Technical

Testing

Screenshot

Stakeholders

@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Dec 7, 2023
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

May be good to write something in the description explaining why this change has been made.

@jimchamp jimchamp merged commit 5af8db3 into master Dec 7, 2023
3 checks passed
@jimchamp jimchamp deleted the 8579/fix/sort-no-follow branch December 7, 2023 22:01
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent Crawlers from hitting sort_options.html links that should be nofollow
2 participants