Fixes translated languages not being localized on edition edit page

[Nick3791]

Closes #8174

Hi, I'm a new contributor, I'm working with @karlitto01 to try to learn more about the codebase and find ways to contribute to OpenLibrary :)

In the issue above, the language an edition was originally translated from did not appear in the localized language on the edition edit page, this is a small fix for that issue.

Technical

I simply wrapped the initial value of the the language field in a '$_()' call. I believe this should correctly translate the text to the localized version.

Testing

Steps I took to test this:

• Setup dev environment
• Built the translation files
• Imported the work mentioned in the issue above (OL16656007W) to the dev environment.
• On the site, changed the language to Deutsch (but could use French like in the original issue)
• Going to the French edition of that work, and clicking "Edit"
  Both the original language from which the work was translated and the language of the current edition should be localized.

Screenshot

Here's the screenshot of the same work as in the original issue, with the page in English, and Deutsch respectively:
English

Deutsch

Stakeholders

@cdrini

[cdrini]

Hi @Nick3791 ! Thanks for the PR :) This won't quite do the trick ; the _ function only translates things that have been translated in our .po files. The translated language names however live in our db.

Look at the function render_language_field ; it takes a third parameter, i18n_name. We'll want to update render_translated_from_language_field to also take a third parameter in the same way! That should fix it.

Note I think the local environment doesn't have all the translated language, so you might not see it change while testing, unfortunately. But if you follow the same pattern as render_language_field, everything should work!

[Nick3791]

Hi @cdrini,

Thanks for reviewing it. I updated the render_translated_from_language_field function to be like render_language_field and updated both places it was being called. It should now display the result from get_language_name rather than the translated version from the _ function.

Unfortunately, as you mentioned, I cannot see the updates on the local environment.

[cdrini]

Tossed it on testing.openlibrary.org ; works like a charm! Thanks @Nick3791 !