Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lists in Solr #8627

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Lists in Solr #8627

merged 4 commits into from
Jan 3, 2024

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Dec 14, 2023

Closes #7815. Feature. Stores lists in solr. Includes both global lists (series) and user lists. This will eventually be used to replace the current lists search implementation which uses postgres.

Depends on #8618

Technical

Stores the names and a number of the aggregated book subjects.
Also some small refactors, including more list types.

Testing

Did a full reindex, and they all correctly appear in solr search results.

Screenshot

image

Stakeholders

@codecov-commenter
Copy link

Codecov Report

Attention: 370 lines in your changes are missing coverage. Please review.

Comparison is base (6b1fdeb) 17.61% compared to head (75a41dc) 16.68%.
Report is 116 commits behind head on master.

Files Patch % Lines
...y/plugins/openlibrary/js/bulk-tagger/BulkTagger.js 0.00% 198 Missing and 25 partials ⚠️
...penlibrary/js/bulk-tagger/BulkTagger/MenuOption.js 0.00% 51 Missing and 3 partials ⚠️
...ulk-tagger/BulkTagger/SortedMenuOptionContainer.js 0.00% 36 Missing and 4 partials ⚠️
...y/plugins/openlibrary/js/bulk-tagger/models/Tag.js 0.00% 27 Missing and 10 partials ⚠️
openlibrary/plugins/openlibrary/js/ile/index.js 0.00% 11 Missing and 1 partial ⚠️
...ibrary/plugins/openlibrary/js/bulk-tagger/index.js 0.00% 2 Missing ⚠️
.../js/ile/utils/SelectionManager/SelectionManager.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8627      +/-   ##
==========================================
- Coverage   17.61%   16.68%   -0.93%     
==========================================
  Files          85       88       +3     
  Lines        4456     4680     +224     
  Branches      782      835      +53     
==========================================
- Hits          785      781       -4     
- Misses       3187     3383     +196     
- Partials      484      516      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini changed the title Feature/lists solr Lists in Solr Dec 30, 2023
@cdrini cdrini marked this pull request as ready for review December 30, 2023 05:29
@cdrini cdrini mentioned this pull request Dec 30, 2023
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Jan 2, 2024
@mekarpeles mekarpeles self-assigned this Jan 2, 2024
@mekarpeles mekarpeles merged commit 2ad32a9 into internetarchive:master Jan 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Solr Next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lists/series in solr
3 participants