Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecation warnings during build #8630

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

jimchamp
Copy link
Collaborator

Changes repository in package.json to conform with the shortcut syntax found here.

This was done to address these types of deprecation warnings, which are seen while building assets:

(node:5804) [DEP0170] DeprecationWarning: The URL github:internetarchive:openlibrary is invalid. Future versions of Node.js will throw an error.

Here's a link to the deprecation.

Technical

Testing

Screenshot

Stakeholders

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a25a77) 16.68% compared to head (1c861cc) 16.68%.
Report is 29 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8630   +/-   ##
=======================================
  Coverage   16.68%   16.68%           
=======================================
  Files          88       88           
  Lines        4680     4680           
  Branches      835      835           
=======================================
  Hits          781      781           
  Misses       3383     3383           
  Partials      516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Matches the syntax on the docs page you linked. I also confirmed this field isn't in the package-lock, so shouldn't cause it to be out-of-date

@cdrini cdrini self-assigned this Dec 15, 2023
@cdrini cdrini merged commit c26dd7c into internetarchive:master Dec 15, 2023
3 checks passed
@jimchamp jimchamp deleted the update-package-dot-json branch January 31, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants