Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix some bug in solr updater refactor #8631

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Hotfix some bug in solr updater refactor #8631

merged 2 commits into from
Dec 15, 2023

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Dec 15, 2023 •
edited

Hotfix.

Technical

Testing

Added unit tests to prevent regression.

Screenshot

Stakeholders

@cdrini cdrini marked this pull request as ready for review December 15, 2023 00:31
@cdrini cdrini added the Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed] label Dec 15, 2023
@cdrini
Copy link
Collaborator Author

cdrini commented Dec 15, 2023

Labelling as P0 since it must go out before the next deploy

scottbarnes
scottbarnes approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@scottbarnes scottbarnes merged commit e34bafe into internetarchive:master Dec 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottbarnes scottbarnes scottbarnes approved these changes

Assignees

@scottbarnes scottbarnes

Labels
Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cdrini @scottbarnes