Adds work subtitles to reading stats #8638
Conversation
|
@cdrini Sorry to bother you but if there is any thing more to fix then kindly let me know I ll do that.. so that this PR can be merged ASAP🙏 |
There was a problem hiding this comment.
Hey @siddoinghisjob ! Could you please attach a screenshot of this working? You should be able to fully test this in your local environment :)
| @@ -13,7 +13,7 @@ | |||
| $jsdef render_works_list(works): | |||
| <ul class="works-list"> | |||
| $for work in works: | |||
| <li><a href="$work.key" style="font-style:oblique">$work.title</a> | |||
| <li><a href="$work.key" style="font-style:oblique">$work.title $work.subtitle</a> | |||
There was a problem hiding this comment.
There should be a : between the title and sub title. Make sure not display the : if there is no subtitle!
cdrini
added
the
Needs: Submitter Input
cdrini
changed the title
cdrini
changed the title
|
|
Hi @cdrini! I have made a PR. Please let me know if you need anything else to be fixed. |
|
Hey @cdrini , it's been a while since I made the changes. Anything more to fix :) |
cdrini
removed
the
Needs: Submitter Input
There was a problem hiding this comment.
Lgtm! Appears correctly on testing.openlibrary.org . Thank you @siddoinghisjob !
Closes #8585 . Adds subtitles along with titles of books in stats
Technical
added subtitle attribute to work_json in mybooks.py and printed it in readinglog_stats.html
Testing
Step 1 : Add a book that has subtitle to Already read
Step 2 : Go to mybook section and click on the My Reading Stats and click on any bar
Screenshot
Stakeholders