Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bulk tagger's "Submit" button after submission is made #8660

Merged
merged 8 commits into from
Dec 27, 2023

Conversation

xonx4l
Copy link
Contributor

@xonx4l xonx4l commented Dec 21, 2023

issue-:#8651

Closes #8651

Fix: Disable 'Submit" button after submission with a loading spinner .

Technical

// Adds state
this.isSubmitting = true;

    // Disable button
    this.submitButton.disabled = true;

    // Show loading spinner
    this.submitButton.textContent = "Submitting...";

Testing

A loading spinner can be seen after submission is made

Stakeholders

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (7e32e7f) 16.68% compared to head (07b90c4) 16.66%.
Report is 3 commits behind head on master.

Files Patch % Lines
...y/plugins/openlibrary/js/bulk-tagger/BulkTagger.js 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8660      +/-   ##
==========================================
- Coverage   16.68%   16.66%   -0.02%     
==========================================
  Files          88       88              
  Lines        4681     4686       +5     
  Branches      835      835              
==========================================
  Hits          781      781              
- Misses       3384     3389       +5     
  Partials      516      516              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimchamp jimchamp self-assigned this Dec 21, 2023
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xonx4l, thanks! I've added a few suggested changes. Aside from those, disregard my comment in the issue thread about the spinner animation --- changing the button's text to "Submitting..." is simpler.

@jimchamp jimchamp changed the title Fix: Disable 'Submit" button after submission is made . Disable bulk tagger's "Submit" button after submission is made Dec 22, 2023
@jimchamp jimchamp added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Dec 22, 2023
xonx4l and others added 6 commits December 23, 2023 09:05
@xonx4l
Copy link
Contributor Author

xonx4l commented Dec 23, 2023

again @jimchamp thanks man for showing the right direction and pointing out the mistakes and helping in my learning .Thanks you very much .Means a lot .

@jimchamp jimchamp added Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] and removed Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] labels Dec 27, 2023
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xonx4l! This is working as expected.

You can use GitHub's UI to add several review suggestions to a single commit. See this documentation for more information.

@jimchamp jimchamp merged commit 71b18af into internetarchive:master Dec 27, 2023
3 checks passed
@xonx4l
Copy link
Contributor Author

xonx4l commented Dec 28, 2023

Thanks @jimchamp will surely go through the documentation . Thanks for your time .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk Tagger: Disable "Submit" button after submission is made
3 participants