-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable bulk tagger's "Submit" button after submission is made #8660
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #8660 +/- ##
==========================================
- Coverage 16.68% 16.66% -0.02%
==========================================
Files 88 88
Lines 4681 4686 +5
Branches 835 835
==========================================
Hits 781 781
- Misses 3384 3389 +5
Partials 516 516 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xonx4l, thanks! I've added a few suggested changes. Aside from those, disregard my comment in the issue thread about the spinner animation --- changing the button's text to "Submitting..." is simpler.
Co-authored-by: jimchamp <jameschamp@acm.org>
Co-authored-by: jimchamp <jameschamp@acm.org>
Co-authored-by: jimchamp <jameschamp@acm.org>
Co-authored-by: jimchamp <jameschamp@acm.org>
Co-authored-by: jimchamp <jameschamp@acm.org>
Co-authored-by: jimchamp <jameschamp@acm.org>
again @jimchamp thanks man for showing the right direction and pointing out the mistakes and helping in my learning .Thanks you very much .Means a lot . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xonx4l! This is working as expected.
You can use GitHub's UI to add several review suggestions to a single commit. See this documentation for more information.
Thanks @jimchamp will surely go through the documentation . Thanks for your time . |
issue-:#8651
Closes #8651
Fix: Disable 'Submit" button after submission with a loading spinner .
Technical
// Adds state
this.isSubmitting = true;
Testing
A loading spinner can be seen after submission is made
Stakeholders