Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSON endpoint for reading goal partials #8662

Conversation

jimchamp
Copy link
Collaborator

Closes #7447

Changes YRG partials endpoint to use JSON encoding.

This endpoint is called whenever a patron sets a yearly reading goal from their /account/books page.

Technical

Testing

Screenshot

Stakeholders

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5643463) 16.68% compared to head (2cc5f78) 16.68%.
Report is 19 commits behind head on master.

Files Patch % Lines
...nlibrary/plugins/openlibrary/js/check-ins/index.js 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8662      +/-   ##
==========================================
- Coverage   16.68%   16.68%   -0.01%     
==========================================
  Files          88       88              
  Lines        4681     4682       +1     
  Branches      835      835              
==========================================
  Hits          781      781              
- Misses       3384     3385       +1     
  Partials      516      516              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jimchamp jimchamp changed the title Use JSON endpoint for reading goal partails Use JSON endpoint for reading goal partials Dec 21, 2023
@mekarpeles mekarpeles self-assigned this Jan 2, 2024
@mekarpeles mekarpeles added the Priority: 2 Important, as time permits. [managed] label Jan 2, 2024
@mekarpeles mekarpeles merged commit 7baa896 into internetarchive:master Jan 16, 2024
4 checks passed
@mekarpeles
Copy link
Member

lgtm!

@jimchamp jimchamp deleted the 7447/refactor/use-json-for-partial-html branch January 31, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2 Important, as time permits. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change /partials endpoint to /partials.json to get gzip support
3 participants