Change header titles for lists, shelves #8666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbarnes
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8665
Breadcrumb selector now shows the fallback English text if no translations are available for the titles of the reading log and list overview pages.
Technical
breadcrumb_titlewas not being set here, due to theselectedstring not matching any of theoptionsthat include a count.selectedis theheader_titlethat is passed toMyBooksTemplate.render. Modifying theheader_titles to include the counts corrected this issue.Testing
Repeat the repro steps found in #8665
Screenshot
Stakeholders