Re-enabled autofill on add new book form #8688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
requested changes
Jan 5, 2024
| @@ -311,7 +312,7 @@ def find_matches( | |||
| return edition or work # Case 3 or 2, from check page | |||
|
|
|||
| edition = self.try_edition_match( | |||
| title=i.title, | |||
| title=i.book_title, | |||
There was a problem hiding this comment.
Suggested change
| title=i.book_title, | |
| title=i.title, |
| @@ -325,7 +326,7 @@ def find_matches( | |||
| solr = get_solr() | |||
| # Less exact solr search than try_edition_match(), search by supplied title and author only. | |||
| result = solr.select( | |||
| {'title': i.title, 'author_key': author_key.split("/")[-1]}, | |||
| {'title': i.book_title, 'author_key': author_key.split("/")[-1]}, | |||
There was a problem hiding this comment.
Suggested change
| {'title': i.book_title, 'author_key': author_key.split("/")[-1]}, | |
| {'title': i.title, 'author_key': author_key.split("/")[-1]}, |
| @@ -458,7 +459,7 @@ def no_match(self, saveutil: DocSaveHelper, i: web.utils.Storage) -> NoReturn: | |||
| """ | |||
| # Any new author has been created and added to | |||
| # saveutil, and author_key added to i | |||
| work = new_doc("/type/work", title=i.title, authors=i.authors) | |||
| work = new_doc("/type/work", title=i.book_title, authors=i.authors) | |||
There was a problem hiding this comment.
Suggested change
| work = new_doc("/type/work", title=i.book_title, authors=i.authors) | |
| work = new_doc("/type/work", title=i.title, authors=i.authors) |
jimchamp
added
the
Needs: Submitter Input
for more information, see https://pre-commit.ci
Sorry for inconvenience! |
jimchamp
approved these changes
Jan 8, 2024
|
No worries! Thanks for making those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8598
Technical
updated
book_titleas the newnameAdded
book_title=""as object to post handler and set the value ofi.titletoi.book_titleTesting
Screenshot
Stakeholders