Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILE: Increasing the visibility of selected works #8742

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

QuantuM410
Copy link
Contributor

Issue: #8659

Proposed Solution

I think it would be better to stick with just sliding up the selection above the ILE blue bar on clicking "N works selected". It would allow the selected works to appear above the blue bar upon click and immediate visibility of the selected works. This implementation would not mess with the drag and drop functionality as mentioned here #8659 (comment) by @cdrini.
Other than that we can also choose to go with an implementation of a drawer or a menu like bulktagger but I am not sure if that won't interfere with the drag and drop functionality. If @cdrini or someone can verify the working of setDragImage API in a drawer or menu, this can be a better solution :). As its been mentioned here #8659 (comment) that
image

Testing

Screenshot

Stakeholders

@jimchamp

@QuantuM410
Copy link
Contributor Author

QuantuM410 commented Jan 23, 2024

I implemented the visibility issue by shifting the selected works above the ile toolbar and made the works clickable as of now. The toggling of "N works selected" have been added to hide or display the selected works. Any review would be appreciated, so I can make a PR! :)

capt-2.mp4

@QuantuM410 QuantuM410 marked this pull request as ready for review January 29, 2024 16:07
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @QuantuM410, and sorry for the delay. I'm going to remove the click listeners and keep the style changes.

Drag and drop feature seems to be working on Firefox, but I can't find documentation on this feature to confirm.

openlibrary/plugins/openlibrary/js/ile/index.js Outdated Show resolved Hide resolved
@jimchamp jimchamp merged commit ae255df into internetarchive:master Feb 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants