Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use GitHub issue form for bug report #8764

Merged
merged 15 commits into from
Feb 27, 2024

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Jan 27, 2024

Progress on #8337 (but still need to convert other templates if we like this)
@mekarpeles

In my opinion, it makes reporting issues a bit easier for new users (and probably experienced ones too).

I tried to stay faithful to the current template with few changes.
After a call with Drini, we decided to drastically simplify the form to just a few inputs (rather than the many you see in the video).

Testing

Visit my fork to see the template in action.

Here is an example of what a created issue looks like.

Screenshot

Old video, the form has since changed
use.GitHub.issue.form.for.bug.report.by.RayBB.Pull.Request.8764.internetarchive_openlibrary.-.27.January.2024.mp4

@RayBB RayBB force-pushed the gh-issue-forms branch 4 times, most recently from 0006de9 to c055a2e Compare January 27, 2024 02:41
@RayBB RayBB marked this pull request as ready for review January 27, 2024 02:50
@RayBB RayBB marked this pull request as ready for review February 4, 2024 20:53
@RayBB RayBB requested a review from cdrini February 4, 2024 20:53
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Feb 20, 2024
@RayBB RayBB added this to Waiting Review/Merge from Staff in Ray's Project via automation Feb 27, 2024
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok a few tweaks! I showed this at the community call a few weeks ago, and folks seemed on board! A few tweaks to tighten things up a bit further here and then should be good to go!

.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
Thanks for taking the time to fill out this bug report! 👍
- type: textarea
attributes:
label: Problem
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a label? Will it work if we just don't have one?

Suggested change
label: Problem

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RayBB and others added 6 commits February 27, 2024 19:04
Co-authored-by: Drini Cami <cdrini@gmail.com>
Co-authored-by: Drini Cami <cdrini@gmail.com>
Co-authored-by: Drini Cami <cdrini@gmail.com>
Co-authored-by: Drini Cami <cdrini@gmail.com>
@RayBB RayBB requested a review from cdrini February 27, 2024 18:11
@RayBB
Copy link
Collaborator Author

RayBB commented Feb 27, 2024

@cdrini I added all your suggestions and I think it looks great now.
Note: the label is required. I tried to improve the label to make it a bit less redundant.

Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, thank you @RayBB !

@cdrini cdrini merged commit 326de6d into internetarchive:master Feb 27, 2024
3 checks passed
Ray's Project automation moved this from Waiting Review/Merge from Staff to Done Feb 27, 2024
Achorn pushed a commit to Achorn/openlibrary that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants