-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk Tagger: Move "Create subject" affordance to bottom of menu options scroll container #8776
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8776 +/- ##
==========================================
- Coverage 16.62% 16.56% -0.06%
==========================================
Files 88 89 +1
Lines 4698 4715 +17
Branches 837 841 +4
==========================================
Hits 781 781
- Misses 3399 3414 +15
- Partials 518 520 +2 ☔ View full report in Codecov by Sentry. |
I was expecting the HTML string, here, to change. Did that not work? |
Yeh I thought of that and that works fine too. The only issue I had with that was with its positioning while searching for a subject when it displays content from Here is how it functions with the moved HTML string to this
out3.mp4 |
@jimchamp Hey! I made the asked changes. It seems the screen recordings I am uploading are facing some encoding issues in firefox browser. After Updating the HTML string : out.mp4Also my previous solution seems to work on my local system for all cases including typing "b" and others too I preferred it as it allowed the affordance to display over the searched subjects once the user scrolled the entire container instead of disappearing again if user scrolls back again. |
Whenever you have a choice between implementing code as per the requirements and implementing the code that you prefer, I recommend choosing to implement what is required. |
Closes #8652
Moved the "Create subject" affordance to the bottom of the scroll container for better visibility and prevention of duplicate subjects.
Technical
Testing
Screenshot
out2.mp4
Stakeholders
@jimchamp