Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Carousel.js #8782

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Feb 1, 2024

Preparatory refactor to #8781

Technical

  • Make carousel component take in data-config like other elements
  • Make it not need a selector; augments the html element it's on.
  • Remove unnecessary index.js file

Testing

  • Tested on pages:
    • ✅ Subjects page
    • ✅* Publishers page
      • Loading more pages doesn't work, but that appears to be broken on staging as well.
    • ✅ Collection page
    • ✅ Homepage ( ✅ books, ✅ welcome, ✅ subjects )
    • ✅ Book page carousels at bottom
    • ✅ My books page components
    • ✅ Loans page components

Screenshot

Stakeholders

- Make it take in data-config like other elements
- Make it not need a selector; augments the html element it's on.
- Remove unnecessary index.js file
@codecov-commenter
Copy link

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (7927be4) 16.62% compared to head (a3a29df) 16.63%.

Files Patch % Lines
...ibrary/plugins/openlibrary/js/carousel/Carousel.js 0.00% 64 Missing and 13 partials ⚠️
openlibrary/plugins/openlibrary/js/index.js 0.00% 4 Missing ⚠️
...brary/plugins/openlibrary/js/carousels_partials.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8782      +/-   ##
==========================================
+ Coverage   16.62%   16.63%   +0.01%     
==========================================
  Files          88       87       -1     
  Lines        4698     4695       -3     
  Branches      838      829       -9     
==========================================
  Hits          781      781              
- Misses       3399     3408       +9     
+ Partials      518      506      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini mentioned this pull request Feb 1, 2024
@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Feb 1, 2024
@cdrini cdrini marked this pull request as ready for review February 1, 2024 05:06
@mekarpeles mekarpeles assigned mekarpeles and jimchamp and unassigned mekarpeles Feb 5, 2024
@cdrini cdrini changed the title Refactor carousel.js Refactor Carousel.js Feb 6, 2024
@mekarpeles mekarpeles added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Feb 12, 2024
@jimchamp jimchamp merged commit c5cea58 into internetarchive:master Feb 22, 2024
4 checks passed
@cdrini cdrini deleted the refactor/carousel-js branch February 23, 2024 08:46
@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants