Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update containers to Python 3.12.2 + Bookworm #8850

Conversation

scottbarnes
Copy link
Collaborator

Update the Docker containers to Debian Bookworm and Python 3.12.

Technical

This update is tied to a specific webpy commit because although the commit has been merged to master, there is not yet a release. Hence using the git hash in requirements.txt.

Testing

Because of the webpy changes, the major Python version changes, and changes to the underlying Debian distribution, it would be good to test out as many tasks as possible.

Stakeholders

@cdrini

scottbarnes and others added 2 commits February 28, 2024 19:26
This update is tied to a specific webpy commit because although the
commit has been merged to master, there is not yet a release. Hence
using the git hash in `requirements.txt`.
@RayBB
Copy link
Collaborator

RayBB commented Feb 29, 2024

Excellent! And when this is merged we can close #8790

Then I can do #8851

@cdrini cdrini self-assigned this Mar 1, 2024
@cdrini
Copy link
Collaborator

cdrini commented Mar 1, 2024

Sweet! This is up on staging.openlibrary.org/status ; will merge / deploy on Monday! 🤞 !

@scottbarnes
Copy link
Collaborator Author

Sweet! This is up on staging.openlibrary.org/status ; will merge / deploy on Monday! 🤞 !

I just looked on staging and things look quite broken. Abort, abort! https://staging.openlibrary.org/works/OL118388W/Flatland?edition=key%3A/books/OL37044775M

@RayBB
Copy link
Collaborator

RayBB commented Mar 2, 2024

@scottbarnes what's wrong with the page? It looks ok to me

@scottbarnes
Copy link
Collaborator Author

@scottbarnes what's wrong with the page? It looks ok to me

Sorry about that, @RayBB. It turns out the error I saw was unrelated to this PR and was fixed by #8859. I forgot to come back here and update this issue.

Unabort! Unabort!

@cdrini cdrini added the Needs: Special Deploy This PR will need a non-standard deploy to production label Mar 5, 2024
@cdrini
Copy link
Collaborator

cdrini commented Mar 5, 2024

Marking as needs special deploy since will need to monitor some of our prod-only containers to see if they are working correctly.

@cdrini cdrini merged commit c1e1dfe into internetarchive:master Mar 5, 2024
3 checks passed
Achorn pushed a commit to Achorn/openlibrary that referenced this pull request Mar 14, 2024
This update is tied to a specific webpy commit because although the
commit has been merged to master, there is not yet a release. Hence
using the git hash in `requirements.txt`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Special Deploy This PR will need a non-standard deploy to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants