Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Author.website UI elements from Author.edit/view templates #8861

Conversation

Dwayne-Lacey
Copy link
Contributor

@Dwayne-Lacey Dwayne-Lacey commented Mar 4, 2024

… removed as Author.website is now deprecated and will be replaced with the links tab. Fix will remove Author.website UI elements during editing and viewing windows as they are no longer needed

Addresses #8293

fix

Technical

Author.website property has UI elements being built within author/edit.html and author/view.html, these references have been removed so that Author.website elements are no longer built.

Testing

View author previously containing a website link on their author page, website link should no longer be visible and when editing author, there should no longer be a website identifier.

Screenshot

image
image

Stakeholders

@hornc @jimchamp

… removed as Author.website is now deprecated and will be replaced with the links tab. Fix will remove Author.website UI elements during editing and viewing windows as they are no longer needed
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dwayne-Lacey, lgtm!

@jimchamp jimchamp merged commit 42f396d into internetarchive:master Mar 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants