Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list add endpoint erroring #8869

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Mar 5, 2024

List seeds can now optionally contain the thing field. This errors was the result of needing to use seed.get('key'), which errors in the JS. I apparently tried to fix this in my previous PR that introduced this issue but messed up the construct!

Technical

Testing

  • ✅ Clicking "Create a list" button on my books page no longer errors
  • ✅ Editing existing list works
  • ✅ Adding notes works

Screenshot

Stakeholders

@cdrini cdrini added the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Mar 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 16.01%. Comparing base (21b78ad) to head (e267bbf).

Files Patch % Lines
openlibrary/plugins/openlibrary/js/jsdef.js 0.00% 1 Missing and 1 partial ⚠️
openlibrary/plugins/openlibrary/js/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8869      +/-   ##
==========================================
- Coverage   16.02%   16.01%   -0.02%     
==========================================
  Files          89       89              
  Lines        4693     4696       +3     
  Branches      818      820       +2     
==========================================
  Hits          752      752              
- Misses       3434     3436       +2     
- Partials      507      508       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini marked this pull request as ready for review March 5, 2024 19:43
@cdrini
Copy link
Collaborator Author

cdrini commented Mar 5, 2024

Scott gave a QA on his local environment and a preliminary review before his meeting, but I want to get this out with the deploy, so am auto merging. Scott will review after the fact!

@cdrini cdrini merged commit ad39696 into internetarchive:master Mar 5, 2024
4 checks passed
@cdrini cdrini deleted the hotfix/list-add-error branch March 5, 2024 20:56
Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jimchamp jimchamp removed the On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants