Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Drop shadow to cover modal #8870

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

QuantuM410
Copy link
Contributor

@QuantuM410 QuantuM410 commented Mar 5, 2024

Closes #8868

This PR aims to add the drop shadow to the covers modal

Technical

I just copied the previously applied css on the covers here

border-radius: 5px;
box-shadow: 1px 1px 2px 0 @book-cover-shadow-color;

Testing

  • Click on any book cover
  • Notice the box shadow

Screenshot

Before
image

After
image

Stakeholders

@RayBB

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.02%. Comparing base (9915746) to head (3c7f835).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8870   +/-   ##
=======================================
  Coverage   16.02%   16.02%           
=======================================
  Files          89       89           
  Lines        4693     4693           
  Branches      818      818           
=======================================
  Hits          752      752           
  Misses       3434     3434           
  Partials      507      507           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this quick PR!
This is a good start. I'm glad you copied the styles from the existing page as that's exactly what we want.

Right now, the css also puts a border around iframes, share modal images (when you click share on the book page), and maybe others too.

Perhaps the css should only apply to images in colorbox with class="cover"

image image

@QuantuM410 QuantuM410 requested a review from RayBB March 6, 2024 14:51
@QuantuM410
Copy link
Contributor Author

Thanks for opening this quick PR! This is a good start. I'm glad you copied the styles from the existing page as that's exactly what we want.

Right now, the css also puts a border around iframes, share modal images (when you click share on the book page), and maybe others too.

Perhaps the css should only apply to images in colorbox with class="cover"
image image

Ah, I see the oversight on my part. I've updated it to apply the drop shadow only to images with the class cover.

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it's working and looks good. Nice job!

Just need a staff member to merge it

@cdrini cdrini merged commit ce8802a into internetarchive:master Mar 7, 2024
3 checks passed
Achorn pushed a commit to Achorn/openlibrary that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add drop shadow to cover modal
4 participants