Show profile page history table conditionally #8902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When viewing a profile page, the history table will now only be rendered for admins and page owners.
|
After a short round of discussions, we want to include Librarians (who may deal w/ anti-spam) to see these tables also. |
|
@jimchamp can we create an issue for this one to link against? On Tuesday we can do a quick check w/ community to make sure we're OK moving forward. |
mekarpeles
added
the
Needs: Community Discussion
mekarpeles
reviewed
Mar 18, 2024
jimchamp
force-pushed
the
secure-profile-page-history-table
branch
from
699aa7f
to
821262e
Compare
for more information, see https://pre-commit.ci
mekarpeles
removed
the
Needs: Community Discussion
Achorn
pushed a commit
to Achorn/openlibrary
that referenced
this pull request
Apr 12, 2024
* Permit librarians, admins, super librarians to view history tables * Show profile page history table conditionally When viewing a profile page, the history table will now only be rendered for librarians, admins, and page owners. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8905
When viewing a profile page, the history table will now only be rendered page owners and members of any of the following usergroups:
adminlibrarianssuper-librariansTechnical
Testing
While logged out:
While logged in with a non-admin account:
While logged in with an admin or librarian account:
Screenshot
Desktop view when history table is not present
Stakeholders