Fix: ensure /api/books defaults to high_priority=False #8919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures `/api/books/` passes `high_priority=False`, even if the endpoint called is _not_ JSON. It appears that this API returns JSON even if one requests `/api/books` and not `/api/books.json`, and that conumers do so call the endpoint this way. Previously, the endpoint only set `high_priority=False` as a default when accessing the JSON endpoint specifically.
cdrini
added
Priority: 1
scottbarnes
deleted the
fix/stop-api-books-from-defaulting-to-high-priority-is-true
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical
This commit ensures
/api/books/passeshigh_priority=False, even if the endpoint called is not JSON. It appears that this API returns JSON even if one requests/api/booksand not/api/books.json, and that conumers do so call the endpoint this way.Previously, the endpoint only set
high_priority=Falseas a default when accessed at/api/books.json.Testing
For both
/api/booksand/api/books.json, visit the respective endpoints without specifying a priority, and observehigh_priority=False, and then specifyhigh_priority=trueand observe thathigh_priority=True.Screenshot
Stakeholders
@cdrini
@mekarpeles