Refactor ol-solr-updater-start.sh to use wget --no-clobber #8921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayBB
added
the
Needs: Review
cdrini
approved these changes
Apr 9, 2024
cdrini
added
Type: Refactor/Clean-up
cdrini
changed the title
Achorn
pushed a commit
to Achorn/openlibrary
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8851
Keeps the code aligned with the Jenkinsfile.
Also it seems a little faster?
Technical
Testing
Start OL. You can follow the steps here if you really wanna see the OSP items there.
#8395
Screenshot
Stakeholders
@cdrini