Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old gitpod prebuild config #8922

Merged
merged 1 commit into from
Mar 31, 2024
Merged

remove old gitpod prebuild config #8922

merged 1 commit into from
Mar 31, 2024

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Mar 20, 2024

Noticed these prebuild settings are deprecated. Prebuilds must be manually turned on here by someone with webhook permissions. As such, we don't need this part of the config file anymore.

Technical

Changed in Oct 2023: https://www.gitpod.io/changelog/simplified-prebuilds-defaults

Testing

I suppose you could open this PR in GitPod but really no testing needed.

Screenshot

Stakeholders

@RayBB RayBB changed the title remove old prebuild config remove old gitpod prebuild config Mar 20, 2024
@RayBB RayBB added the Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] label Mar 20, 2024
@cdrini cdrini removed their assignment Mar 28, 2024
Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @RayBB!

@scottbarnes scottbarnes merged commit ff56408 into master Mar 31, 2024
3 checks passed
@scottbarnes scottbarnes deleted the remove-prebuilds branch March 31, 2024 14:13
Achorn pushed a commit to Achorn/openlibrary that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants