remove setup_jquery_urls #8940
Merged
remove setup_jquery_urls #8940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayBB
added
Type: Refactor/Clean-up
|
Also removing on olsystem openlibrary.yml side (internal, staff) https://github.com/internetarchive/olsystem/blob/master/etc/openlibrary.yml#L169 |
|
@mekarpeles fyi those are private repos so just 404 for me. |
|
@jimchamp could this be reviewed this week? |
jimchamp
added
the
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was poking around looking at #2340 and found this code for getting the jquery urls. I'm pretty sure this is long dead. I couldn't find a single reference to any of these variables or urls and I doubt if we've loaded from a CDN for a long time.