Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cancel button to book Edit Page and made layout of book edit pa… #8946

Conversation

Realmbird
Copy link
Contributor

@Realmbird Realmbird commented Mar 22, 2024

Makes book edit page consistent with author edit page by changing layout and adding cancel button

Closes #8883

Feature: Adds Cancel button to author edit page

Technical

Changes the html in order to reorder the book edit page to look consistent with author page
This implementation also adds cancel button to books that are recently added

Testing

  1. docker compose up
  2. http://localhost:8080/
  3. Go find a book
  4. make Edit on book
    5. Look at side to see cancel button

Screenshot

New

Screenshot from 2024-03-22 11-05-35
Screenshot from 2024-03-22 11-08-03

Before

Screenshot from 2024-03-22 11-08-57

Stakeholders

@RayBB

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Realmbird Good work with your PR! Just a few small changes and you're good to go :)

openlibrary/templates/books/edit.html Outdated Show resolved Hide resolved
openlibrary/templates/books/edit.html Outdated Show resolved Hide resolved
@RayBB RayBB added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Mar 23, 2024
@RayBB RayBB added Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] and removed Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] labels Mar 24, 2024
Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I tested and it's working nicely. Now we just need staff to merge it.

Hope you can join in fixing more issues soon :)

openlibrary/templates/books/edit.html Outdated Show resolved Hide resolved
@RayBB RayBB added Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] and removed Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] labels Mar 26, 2024
@RayBB
Copy link
Collaborator

RayBB commented Apr 2, 2024

@Realmbird please make the final changes requested so we can merge this.

Changed it so that Cancel shows regardless of user

Co-authored-by: Raymond Berger <RayBB@users.noreply.github.com>
Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great for me!

@RayBB RayBB added Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. and removed Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] labels Apr 2, 2024
Copy link
Collaborator

@jimchamp jimchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! The only issue that I'm seeing is that the cancel link always points to the Work page, even if we're looking at an Edition page.

@jimchamp jimchamp merged commit 9387426 into internetarchive:master Apr 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cancel button to top books edit page
3 participants