-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Cancel button to book Edit Page and made layout of book edit pa… #8946
Added Cancel button to book Edit Page and made layout of book edit pa… #8946
Conversation
…ge consistent with author edit page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Realmbird Good work with your PR! Just a few small changes and you're good to go :)
…'t be seen by people not authors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I tested and it's working nicely. Now we just need staff to merge it.
Hope you can join in fixing more issues soon :)
@Realmbird please make the final changes requested so we can merge this. |
Changed it so that Cancel shows regardless of user Co-authored-by: Raymond Berger <RayBB@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working great for me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! The only issue that I'm seeing is that the cancel link always points to the Work
page, even if we're looking at an Edition
page.
Makes book edit page consistent with author edit page by changing layout and adding cancel button
Closes #8883
Feature: Adds Cancel button to author edit page
Technical
Changes the html in order to reorder the book edit page to look consistent with author page
This implementation also adds cancel button to books that are recently added
Testing
5. Look at side to see cancel button
Screenshot
New
Before
Stakeholders
@RayBB