Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add typehints to dateutil.py #8956

Merged
merged 1 commit into from
Mar 31, 2024
Merged

add typehints to dateutil.py #8956

merged 1 commit into from
Mar 31, 2024

Conversation

RayBB
Copy link
Collaborator

@RayBB RayBB commented Mar 25, 2024 •
edited
Loading

Just adding some typehints

Technical

Testing

Screenshot

Stakeholders

@RayBB RayBB added the Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed] label Mar 25, 2024
scottbarnes
scottbarnes approved these changes Mar 31, 2024
View reviewed changes
Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @RayBB!

@scottbarnes scottbarnes merged commit cb8ea8f into master Mar 31, 2024
3 checks passed
@scottbarnes scottbarnes deleted the typehints/dateutil branch March 31, 2024 14:00
Achorn pushed a commit to Achorn/openlibrary that referenced this pull request Apr 12, 2024
@RayBB @Achorn
add typehints to dateutil.py (internetarchive#8956)
faa9e83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottbarnes scottbarnes scottbarnes approved these changes

Assignees

@scottbarnes scottbarnes

Labels
Needs: Review This issue/PR needs to be reviewed in order to be closed or merged (see comments). [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RayBB @scottbarnes