remove the word beta from Solr Editions #8984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanig1
force-pushed
the
8979/fix/remove-beta-from-edition-search
branch
from
4bee25a
to
181ec50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8979
fix: remove word 'beta' from 'Solr Editions Beta' (as it is no longer in beta link)
Technical
first commit updates the i18n value as the key itself had the beta word
second commit removes beta from the actual translations
Testing
Running locally:
http://localhost:8080/search?q=%22a%22&mode=everything&first_publish_year=2023&publisher_facet=Norton+%26+Company%2C+Incorporated%2C+W.+W.&sort=readinglogScreenshot
Before:
After (tested locally with admin account):
Stakeholders