Set default author book count to zero #9004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
force-pushed
the
bug/default-count-on-null
branch
2 times, most recently
from
1a94b68
to
7ccec46
Compare
jimchamp
force-pushed
the
bug/default-count-on-null
branch
from
7ccec46
to
dac2fb6
Compare
jimchamp
added
On testing.openlibrary.org
jimchamp
changed the title
cdrini
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Lgtm one small code quality comment! Merge at your discretion.
Confirmed https://testing.openlibrary.org/authors/OL120205A/Marcel_Proust?has_fulltext=true&q=1%C0%A7%C0%A2%252527%252522%5C%27%5C%22&debug=true now loads on testing.
cdrini
added
the
Needs: Submitter Input
jimchamp
added
On testing.openlibrary.org
cdrini
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Naive solution for these Sentry events.
books.num_foundcan sometimes beNone. This change creates a newnum_foundvariable that hold the immutablebooks.num_foundvalue, or 0 if none exists.Technical
Testing
This page fails to load in production, but works in testing with this branch deployed.
Screenshot
Stakeholders