Feature: remove suspect publish_date values from AMZ/BWB
#9009
+140
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain import sources, such as Amazon and BWB, have `publish_date` values that are known to be suspect, such as `1900` or `January 1, 1900`. This commit removes the `publish_date` value from those import records prior to import.
scottbarnes
deleted the
feature/8969/stop-importing-from-aws-and-bwb-if-publish-date-is-1900
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8969
Certain import sources, such as Amazon and BWB, have
publish_datevalues that are known to be suspect, such as1900orJanuary 1, 1900.This commit removes the
publish_datevalue from those import records prior to import.Specifically, the
publish_datevalue is removed in the following situations:source_recordvalue starting withamazon,bwb, orpromise; andpublish_dateis either1900orJanuary 1, 1900.Questions
I want to verify the above above conditions for removal are correct.
Testing
See the unit tests.
Stakeholders
@mekarpeles
@judec
@hornc