set All as default for search bar #9032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayBB
added
the
Needs: Review
jimchamp
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Thanks @RayBB!
The flash still exists if the patron has selected something other than All. This wouldn't be an issue if we didn't set the search mode to the last selected mode...
Anyway, I think that this prevents the flash for most patrons in most cases, which seems like a win to me.
jimchamp
added
On testing.openlibrary.org
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever notice how every time you go to a page on OL the search bar selector flickers a bit?
Current issue
Well this will fix it. At least for all the users that keep it set to the default of All.
After this PR
Technical
Testing
Screenshot
Stakeholders