Feature: add osp as import source #9034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include `osp:` as a source record and point to ISBNdb, as it is the source of data for OSP-sourced imports. Pursuant to internetarchive#8589 we want to import ISBNdb records, based on ISBNs from OSP that are not already in Open Library. We also want to track these records, so we settled on including `osp:<isbn_13>` in the `source_records` field. But if it's in the source records field, we should handle it 'properly' as a source record so it doesn't falsely display as a MARC record instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes #8589.
Include
osp:as a source record and point to ISBNdb, as it is the source of data for OSP-sourced imports.Pursuant to #8589 we want to import ISBNdb records, based on ISBNs from OSP that are not already in Open Library. We also want to track these records, so we settled on including
osp:<isbn_13>in thesource_recordsfield. But if it's in the source records field, we should handle it 'properly' as a source record so it doesn't falsely display as a MARC record instead.Technical
Note,
osp:will currently only show in an import record if (1) we 'fix' the import sources history so it doesn't always display the last source record, or (2)osp:isn't the last source record.Currently OSP records have been imported with the
idb:source record as last, so it displays.Testing
Screenshot
Without this PR applied:
With the PR applied:
Stakeholders
@mekarpeles