Reduce default limit of readinglog API to 100 #9046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
force-pushed
the
fix/paginate-readinglog-api
branch
from
1e398ac
to
ecd88a3
Compare
And add numFound field for easier pagination
cdrini
force-pushed
the
fix/paginate-readinglog-api
branch
from
ecd88a3
to
9cbe3cc
Compare
cdrini
added
the
On testing.openlibrary.org
scottbarnes
reviewed
Apr 12, 2024
scottbarnes
added
the
Needs: Submitter Input
cdrini
commented
Apr 13, 2024
scottbarnes
removed
the
Needs: Submitter Input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8852 . The readinglog APIs were fetching with a default of 5000. That's too much for a default, so reduce that to 100. Also add a total
numFoundfield to the response to make pagination easier.Note this is a BREAKING CHANGE to a public API, but I think it's required for healthy site/solr performance. Also because of the bug in #8852 , it would error if you tried to get a lot of books in one go anyways.
Technical
Testing
Screenshot
Stakeholders
@mheiman