Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused User method #9049

Merged

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Apr 8, 2024

Closes #

Removes unused and obsolete method for determining if a patron has access to librarian tools.

Note

After deployment, this usergroup can be removed.

Technical

Testing

Screenshot

Stakeholders

Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scottbarnes scottbarnes merged commit 03fcfba into internetarchive:master Apr 12, 2024
3 checks passed
Achorn pushed a commit to Achorn/openlibrary that referenced this pull request Apr 12, 2024
@jimchamp jimchamp deleted the remove-librarian-tools-usergroup branch April 24, 2024 00:01
@mekarpeles
Copy link
Member

Here was the state of librarian-tools before we made it /type/delete

{ "description": "Librarians who are permitted to use work merge UI.", "key": "/usergroup/librarian-tools", "m": "edit", "members": [ { "key": "/people/seabelis" }, { "key": "/people/glbw" }, { "key": "/people/jehanni" }, { "key": "/people/mekBot" }, { "key": "/people/ScarTissue" }, { "key": "/people/jachamp" }, { "key": "/people/mheiman9541" }, { "key": "/people/tmanarl" }, { "key": "/people/dcapillae" }, { "key": "/people/raybb" }, { "key": "/people/bitnapper" }, { "key": "/people/jeneewhitney" }, { "key": "/people/yellowgalaxy" }, { "key": "/people/mekBot" }, { "key": "/people/mekarpeles" } ], "type": { "key": "/type/usergroup" }, "latest_revision": 10, "revision": 10, "created": { "type": "/type/datetime", "value": "2021-10-05T21:45:48.978152" }, "last_modified": { "type": "/type/datetime", "value": "2022-06-29T17:39:22.214506" } }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants