Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated regex 'path' of isbn and added canonical to have correct isbn #9074

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

QuantuM410
Copy link
Contributor

Closes #8964

This PR aims to extract valid isbns from the /isbn/{isbn} path to avoid unnecessary manual stripping of unwanted characters in {isbn}

Technical

Testing

Screenshot

Stakeholders

@RayBB @scottbarnes

Copy link
Collaborator

@scottbarnes scottbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, @QuantuM410!

@scottbarnes scottbarnes merged commit fc52436 into internetarchive:master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

strip underscores from the isbn endpoint
2 participants