Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated version tags from docker compose files #9094

Conversation

BaasanbayarOverflow
Copy link
Contributor

Closes #9092

Fix

Technical

Removed "VERSION" tags from docker compose files

Testing

Screenshot

Stakeholders

@RayBB

@BaasanbayarOverflow BaasanbayarOverflow changed the title remove version tags Remove version tags Apr 16, 2024
Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job thanks for doing this! 👍
We just need staff to merge now!

@RayBB
Copy link
Collaborator

RayBB commented Apr 17, 2024

@scottbarnes can you merge this?

@scottbarnes
Copy link
Collaborator

@RayBB, I imagine it's exceedingly unlikely this change will face any opposition, but other things being equal, PRs aren't meant to be merged until the associated issue has gone through triage on Monday so that the core team can be aware of all potential changes and have time to raise any issues.

@RayBB
Copy link
Collaborator

RayBB commented Apr 17, 2024

@scottbarnes thanks for the heads up that's good to know. Is this written anywhere in the process docs? Maybe we should add a note to be clear about it.

@scottbarnes
Copy link
Collaborator

@scottbarnes thanks for the heads up that's good to know. Is this written anywhere in the process docs? Maybe we should add a note to be clear about it.

To my knowledge it's not. But yes it should be somewhere. I think one of the issues we face is that we want things somewhere but it's not always obvious where it should be. Not that this excuses it not being documented.

I'll take responsibility for trying to find a place for this.

@mekarpeles mekarpeles merged commit 65a59ca into internetarchive:master Apr 22, 2024
3 checks passed
@cdrini cdrini added the Needs: Special Deploy This PR will need a non-standard deploy to production label Apr 30, 2024
@cdrini cdrini changed the title Remove version tags Remove deprecated version tags from docker compose files Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Special Deploy This PR will need a non-standard deploy to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove version tags from docker compose files
5 participants