Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to "My Books" page on Google sign-in #9109

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

jimchamp
Copy link
Collaborator

Closes #9108

Sets the default redirect value for Google sign-in to /account/books, the "My Books" page.

This conforms with our default redirect value for email and password authentication, set here:

if i.redirect == "" or any(path in i.redirect for path in blacklist):
i.redirect = "/account/books"

Technical

Testing

  1. Visit the log in page, and sign-in using your Google account.
  2. Ensure that you're redirected to the "My Books" page.

Screenshot

Stakeholders

@mekarpeles mekarpeles merged commit 7221e27 into master Apr 22, 2024
3 checks passed
@jimchamp jimchamp deleted the jimchamp-patch-1 branch April 23, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default login redirects for Google sign-in and email sign-in are different
2 participants