New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mailing lists heading from about page #9132
base: master
Are you sure you want to change the base?
Remove mailing lists heading from about page #9132
Conversation
I think we only want the changes to openlibrary/templates/type/about/view.html and not infogami |
Yup @noobCoderVP you can just remove the infogami changes and then we are good to go. Edit: more info about the infogami files here https://internetarchive.slack.com/archives/C0ETZV72L/p1713794942035489?thread_ts=1713792574.458309&cid=C0ETZV72L |
…sts-from-about-us-page
…tps://github.com/noobCoderVP/openlibrary into 9080/bug/remove-mailing-lists-from-about-us-page
Hey @RayBB could you help me remove the infogami changes? I tried everything like git restore --staged & git reset --hard but I am not able to figure it out, please help me out |
@noobCoderVP can you try |
@noobCoderVP, if that doesn't work, you can try: git reset --soft bee8ab4e369a500e1e31f73d3f06fb88e7c5896f
git restore --staged vendor/infogami
make git
git commit If you do |
@noobCoderVP did Scott's instructions work okay for you? |
I need to check that out @RayBB, got busy with university's final exams. Will do that tonight, sorry for the delay |
Closes #9080
fix
Technical
Removing the mailing list heading
Testing
Test it before merging because I am getting below error in local dev environment
Screenshot
Stakeholders