Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mailing lists heading from about page #9132

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

noobCoderVP
Copy link
Contributor

@noobCoderVP noobCoderVP commented Apr 21, 2024

Closes #9080

fix

Technical

Removing the mailing list heading
image

Testing

Test it before merging because I am getting below error in local dev environment
image

Screenshot

Stakeholders

@mekarpeles
Copy link
Member

I think we only want the changes to openlibrary/templates/type/about/view.html and not infogami

@RayBB
Copy link
Collaborator

RayBB commented Apr 22, 2024

Yup @noobCoderVP you can just remove the infogami changes and then we are good to go.
That page doesn't show up on your local instance because it isn't in the local instance testing data.

Edit: more info about the infogami files here https://internetarchive.slack.com/archives/C0ETZV72L/p1713794942035489?thread_ts=1713792574.458309&cid=C0ETZV72L

@noobCoderVP
Copy link
Contributor Author

Hey @RayBB could you help me remove the infogami changes? I tried everything like git restore --staged & git reset --hard but I am not able to figure it out, please help me out

@RayBB
Copy link
Collaborator

RayBB commented Apr 26, 2024

@noobCoderVP can you try cding into the infogami directory and then doing a git reset? Then leave again and commit the changes.

@scottbarnes
Copy link
Collaborator

@noobCoderVP, if that doesn't work, you can try:

git reset --soft bee8ab4e369a500e1e31f73d3f06fb88e7c5896f
git restore --staged vendor/infogami
make git
git commit

If you do git log -p first you can look at the commit hashes to see where you're resetting to, and if you do git status at each step it may make more sense about what's happening. As for make git, see the git entry in Makefile to see what that's actually doing.

@RayBB RayBB added the Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed] label Apr 28, 2024
@RayBB
Copy link
Collaborator

RayBB commented May 2, 2024

@noobCoderVP did Scott's instructions work okay for you?

@noobCoderVP
Copy link
Contributor Author

noobCoderVP commented May 2, 2024

I need to check that out @RayBB, got busy with university's final exams. Will do that tonight, sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Submitter Input Waiting on input from the creator of the issue/pr [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mailing lists from the about us page
4 participants